This job view page is being replaced by Spyglass soon. Check out the new job view.
PRwojtek-t: [WIP] Pf remove goroutine
ResultFAILURE
Tests 2 failed / 40 succeeded
Started2021-07-29 16:31
Elapsed47m34s
Revision5ce93add574d81c63ce3a57f11cf1d0a86c798ba
Refs 104010

Test Failures


verify gofmt 17s

make verify WHAT=gofmt
diff -u ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/queueset/queueset.go.orig ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/queueset/queueset.go
--- ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/queueset/queueset.go.orig	2021-07-29 16:48:49.404803271 +0000
+++ ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/queueset/queueset.go	2021-07-29 16:48:49.404803271 +0000
@@ -288,31 +288,31 @@
 	// of well-counted goroutines. We Are Told that every
 	// request's context's Done channel gets closed by the time
 	// the request is done being processed.
-/*	doneCh := ctx.Done()
+	/*	doneCh := ctx.Done()
 
-	// Retrieve the queueset configuration name while we have the lock
-	// and use it in the goroutine below.
-	configName := qs.qCfg.Name
+		// Retrieve the queueset configuration name while we have the lock
+		// and use it in the goroutine below.
+		configName := qs.qCfg.Name
 
-	if doneCh != nil {
-		klog.Errorf("EEEEEEEEEEEEEE")
-		panic("EEEEEE")
-		qs.preCreateOrUnblockGoroutine()
-		go func() {
-//			defer runtime.HandleCrash()
-			qs.goroutineDoneOrBlocked()
-			_ = <-doneCh
-			// Whatever goroutine unblocked the preceding receive MUST
-			// have already either (a) incremented qs.counter or (b)
-			// known that said counter is not actually counting or (c)
-			// known that the count does not need to be accurate.
-			// BTW, the count only needs to be accurate in a test that
-			// uses FakeEventClock::Run().
-			klog.V(6).Infof("QS(%s): Context of request %q %#+v %#+v is Done", configName, fsName, descr1, descr2)
-			qs.cancelWait(req)
-			qs.goroutineDoneOrBlocked()
-		}()
-	}*/
+		if doneCh != nil {
+			klog.Errorf("EEEEEEEEEEEEEE")
+			panic("EEEEEE")
+			qs.preCreateOrUnblockGoroutine()
+			go func() {
+	//			defer runtime.HandleCrash()
+				qs.goroutineDoneOrBlocked()
+				_ = <-doneCh
+				// Whatever goroutine unblocked the preceding receive MUST
+				// have already either (a) incremented qs.counter or (b)
+				// known that said counter is not actually counting or (c)
+				// known that the count does not need to be accurate.
+				// BTW, the count only needs to be accurate in a test that
+				// uses FakeEventClock::Run().
+				klog.V(6).Infof("QS(%s): Context of request %q %#+v %#+v is Done", configName, fsName, descr1, descr2)
+				qs.cancelWait(req)
+				qs.goroutineDoneOrBlocked()
+			}()
+		}*/
 	return req, false
 }
 
diff -u ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/interface.go.orig ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/interface.go
--- ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/interface.go.orig	2021-07-29 16:48:49.408803566 +0000
+++ ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/interface.go	2021-07-29 16:48:49.408803566 +0000
@@ -16,7 +16,7 @@
 
 package promise
 
-import(
+import (
 	"sync"
 )
 
diff -u ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise.go.orig ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise.go
--- ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise.go.orig	2021-07-29 16:48:49.408803566 +0000
+++ ./staging/src/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise.go	2021-07-29 16:48:49.408803566 +0000
@@ -42,7 +42,7 @@
 // NewWriteOnce makes a new promise.LockingWriteOnce
 func NewWriteOnce(activeCounter counter.GoRoutineCounter) WriteOnce {
 	return &promise{
-		doneCh:       make(chan struct{}),
+		doneCh:        make(chan struct{}),
 		activeCounter: activeCounter,
 	}
 }

Run ./hack/update-gofmt.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify staticcheck 5m39s

make verify WHAT=staticcheck
Errors from staticcheck:
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise_test.go:32:21: cannot use &lock (value of type *sync.Mutex) as counter.GoRoutineCounter value in argument to NewWriteOnce: missing method Add (compile)
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise_test.go:32:28: too many arguments (compile)
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise_test.go:40:13: too many arguments (compile)
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise_test.go:40:20: too few arguments in call to wr.Get (compile)
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise_test.go:84:13: too many arguments (compile)
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise_test.go:84:20: too few arguments in call to wr.Get (compile)
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise_test.go:117:13: 2-valued wr.Get() (value of type (interface{}, error)) where single value is expected (compile)
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/promise_test.go:117:20: too few arguments in call to wr.Get (compile)
vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/queueset/queueset.go:865:21: func (*queueSet).preCreateOrUnblockGoroutine is unused (U1000)

Please review the above warnings. You can test via:
  hack/verify-staticcheck.sh <failing package>
If the above warnings do not make sense, you can exempt the line or file. See:
  https://staticcheck.io/docs/#ignoring-problems
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 40 Passed Tests