PRerrordeveloper: WIP: Refactor most of `kubectl drain` as a library
ResultFAILURE
Tests 6 failed / 27 succeeded
Started2019-01-11 18:44
Elapsed36m7s
Revision
Buildergke-prow-containerd-pool-99179761-3w8w
Refs master:d2d9a3ab
72827:6bc7201d
podd6bfda33-15d0-11e9-84bb-0a580a6c0361
infra-commit7d5cca6b5
podd6bfda33-15d0-11e9-84bb-0a580a6c0361
repok8s.io/kubernetes
repo-commit8b138352e7fa9c9af257d26e2f794a135b0e8e13
repos{u'k8s.io/kubernetes': u'master:d2d9a3aba471e56e1a753a05061dc6cb60137711,72827:6bc7201da21e0989abbbdeca5f979034ded97183'}

Test Failures


verify bazel 13s

make verify WHAT=bazel
diff -Naupr -x _output /go/src/k8s.io/kubernetes/pkg/util/node/drain/BUILD /tmp/verify-bazel.fAkTSy/go/src/k8s.io/kubernetes/pkg/util/node/drain/BUILD
--- /go/src/k8s.io/kubernetes/pkg/util/node/drain/BUILD	2019-01-11 18:45:11.796456242 +0000
+++ /tmp/verify-bazel.fAkTSy/go/src/k8s.io/kubernetes/pkg/util/node/drain/BUILD	2019-01-11 18:49:37.944138207 +0000
@@ -2,7 +2,10 @@ load("@io_bazel_rules_go//go:def.bzl", "
 
 go_library(
     name = "go_default_library",
-    srcs = ["drain.go"],
+    srcs = [
+        "drain.go",
+        "filters.go",
+    ],
     importpath = "k8s.io/kubernetes/pkg/util/node/drain",
     visibility = ["//visibility:public"],
     deps = [

Run ./hack/update-bazel.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify cli-conventions 58s

make verify WHAT=cli-conventions
2019/01/11 18:50:23 Code for OpenAPI definitions generated
# k8s.io/kubernetes/pkg/kubectl/cmd/drain
pkg/kubectl/cmd/drain/drain.go:322:27: cannot use pods (type *drain.podDeleteList) as type []"k8s.io/kubernetes/vendor/k8s.io/api/core/v1".Pod in argument to o.deleteOrEvictPods
pkg/kubectl/cmd/drain/drain.go:329:24: cannot range over pendingPods (type *drain.podDeleteList)
pkg/kubectl/cmd/drain/drain.go:342:29: undefined: drain.SupportEviction
!!! [0111 18:50:43] Call tree:
!!! [0111 18:50:43]  1: /go/src/k8s.io/kubernetes/hack/lib/golang.sh:624 kube::golang::build_some_binaries(...)
!!! [0111 18:50:43]  2: /go/src/k8s.io/kubernetes/hack/lib/golang.sh:758 kube::golang::build_binaries_for_platform(...)
!!! [0111 18:50:43]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0111 18:50:43] Call tree:
!!! [0111 18:50:43]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0111 18:50:43] Call tree:
!!! [0111 18:50:43]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [all] Error 1
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify generated-docs 1m30s

make verify WHAT=generated-docs
# k8s.io/kubernetes/pkg/kubectl/cmd/drain
pkg/kubectl/cmd/drain/drain.go:322:27: cannot use pods (type *drain.podDeleteList) as type []"k8s.io/kubernetes/vendor/k8s.io/api/core/v1".Pod in argument to o.deleteOrEvictPods
pkg/kubectl/cmd/drain/drain.go:329:24: cannot range over pendingPods (type *drain.podDeleteList)
pkg/kubectl/cmd/drain/drain.go:342:29: undefined: drain.SupportEviction
!!! [0111 18:58:39] Call tree:
!!! [0111 18:58:39]  1: /go/src/k8s.io/kubernetes/hack/lib/golang.sh:624 kube::golang::build_some_binaries(...)
!!! [0111 18:58:39]  2: /go/src/k8s.io/kubernetes/hack/lib/golang.sh:758 kube::golang::build_binaries_for_platform(...)
!!! [0111 18:58:39]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0111 18:58:39] Call tree:
!!! [0111 18:58:39]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0111 18:58:39] Call tree:
!!! [0111 18:58:39]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [all] Error 1
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify golint 1m29s

make verify WHAT=golint
Errors from golint:
pkg/util/node/drain/drain.go:34:2: exported const EvictionKind should have comment (or a comment on this block) or be unexported
pkg/util/node/drain/drain.go:45:6: exported type Options should have comment or be unexported
pkg/util/node/drain/drain.go:92:1: exported method Options.DeletePod should have comment or be unexported
pkg/util/node/drain/drain.go:101:1: exported method Options.EvictPod should have comment or be unexported
pkg/util/node/drain/drain.go:126:1: exported method Options.GetPodsForDeletion should have comment or be unexported
pkg/util/node/drain/filters.go:83:2: exported const PodDeleteStatusTypeOkay should have comment (or a comment on this block) or be unexported

Please review the above warnings. You can test via "golint" and commit the result.
If the above warnings do not make sense, you can exempt this package from golint
checking by adding it to hack/.golint_failures (if your reviewer is okay with it).
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify govet 2m26s

make verify WHAT=govet
2019/01/11 19:13:57 Code for OpenAPI definitions generated
# k8s.io/kubernetes/pkg/kubectl/cmd/drain
pkg/kubectl/cmd/drain/drain.go:322:27: cannot use pods (type *drain.podDeleteList) as type []"k8s.io/kubernetes/vendor/k8s.io/api/core/v1".Pod in argument to o.deleteOrEvictPods
pkg/kubectl/cmd/drain/drain.go:329:24: cannot range over pendingPods (type *drain.podDeleteList)
pkg/kubectl/cmd/drain/drain.go:342:29: undefined: drain.SupportEviction
make[1]: *** [vet] Error 1
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify symbols 7.44s

make verify WHAT=symbols
# k8s.io/kubernetes/pkg/kubectl/cmd/drain
pkg/kubectl/cmd/drain/drain.go:322:27: cannot use pods (type *drain.podDeleteList) as type []"k8s.io/kubernetes/vendor/k8s.io/api/core/v1".Pod in argument to o.deleteOrEvictPods
pkg/kubectl/cmd/drain/drain.go:329:24: cannot range over pendingPods (type *drain.podDeleteList)
pkg/kubectl/cmd/drain/drain.go:342:29: undefined: drain.SupportEviction
!!! [0111 19:20:11] Call tree:
!!! [0111 19:20:11]  1: /go/src/k8s.io/kubernetes/hack/lib/golang.sh:624 kube::golang::build_some_binaries(...)
!!! [0111 19:20:11]  2: /go/src/k8s.io/kubernetes/hack/lib/golang.sh:758 kube::golang::build_binaries_for_platform(...)
!!! [0111 19:20:11]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0111 19:20:11] Call tree:
!!! [0111 19:20:11]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0111 19:20:11] Call tree:
!!! [0111 19:20:11]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [all] Error 1
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 27 Passed Tests