PRMrHohn: Graduate CustomPodDNS feature to GA
ResultFAILURE
Tests 2 failed / 31 succeeded
Started2019-01-11 18:46
Elapsed38m20s
Revision
Buildergke-prow-containerd-pool-99179761-bkpl
Refs master:d2d9a3ab
72832:2d446d44
pod12496159-15d1-11e9-8954-0a580a6c019d
infra-commit7d5cca6b5
pod12496159-15d1-11e9-8954-0a580a6c019d
repok8s.io/kubernetes
repo-commitbcd15c420bc5c0921219b5fec9779fb623ffa033
repos{u'k8s.io/kubernetes': u'master:d2d9a3aba471e56e1a753a05061dc6cb60137711,72832:2d446d44bd797223aa9f5a6b208d4c11dc9faebd'}

Test Failures


verify bazel 13s

make verify WHAT=bazel
diff -Naupr -x _output /go/src/k8s.io/kubernetes/pkg/kubelet/network/dns/BUILD /tmp/verify-bazel.IIiLkQ/go/src/k8s.io/kubernetes/pkg/kubelet/network/dns/BUILD
--- /go/src/k8s.io/kubernetes/pkg/kubelet/network/dns/BUILD	2019-01-11 18:47:11.352489776 +0000
+++ /tmp/verify-bazel.IIiLkQ/go/src/k8s.io/kubernetes/pkg/kubelet/network/dns/BUILD	2019-01-11 18:51:30.388329056 +0000
@@ -7,13 +7,11 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//pkg/apis/core/validation:go_default_library",
-        "//pkg/features:go_default_library",
         "//pkg/kubelet/apis/cri/runtime/v1alpha2:go_default_library",
         "//pkg/kubelet/container:go_default_library",
         "//pkg/kubelet/util/format:go_default_library",
         "//staging/src/k8s.io/api/core/v1:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/util/errors:go_default_library",
-        "//staging/src/k8s.io/apiserver/pkg/util/feature:go_default_library",
         "//staging/src/k8s.io/client-go/tools/record:go_default_library",
         "//vendor/k8s.io/klog:go_default_library",
     ],
@@ -24,14 +22,11 @@ go_test(
     srcs = ["dns_test.go"],
     embed = [":go_default_library"],
     deps = [
-        "//pkg/features:go_default_library",
         "//pkg/kubelet/apis/cri/runtime/v1alpha2:go_default_library",
         "//staging/src/k8s.io/api/core/v1:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/types:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library",
-        "//staging/src/k8s.io/apiserver/pkg/util/feature:go_default_library",
-        "//staging/src/k8s.io/apiserver/pkg/util/feature/testing:go_default_library",
         "//staging/src/k8s.io/client-go/tools/record:go_default_library",
         "//vendor/github.com/stretchr/testify/assert:go_default_library",
         "//vendor/github.com/stretchr/testify/require:go_default_library",

Run ./hack/update-bazel.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify gofmt 14s

make verify WHAT=gofmt
diff -u ./pkg/kubelet/network/dns/dns_test.go.orig ./pkg/kubelet/network/dns/dns_test.go
--- ./pkg/kubelet/network/dns/dns_test.go.orig	2019-01-11 19:13:31.373180905 +0000
+++ ./pkg/kubelet/network/dns/dns_test.go	2019-01-11 19:13:31.373180905 +0000
@@ -288,12 +288,12 @@
 	}
 
 	testCases := []struct {
-		desc                    string
-		hasClusterDNS           bool
-		hostNetwork             bool
-		dnsPolicy               v1.DNSPolicy
-		expectedDNSType         podDNSType
-		expectedError           bool
+		desc            string
+		hasClusterDNS   bool
+		hostNetwork     bool
+		dnsPolicy       v1.DNSPolicy
+		expectedDNSType podDNSType
+		expectedError   bool
 	}{
 		{
 			desc:            "valid DNSClusterFirst without hostnetwork",
@@ -333,9 +333,9 @@
 			expectedDNSType: podDNSHost,
 		},
 		{
-			desc:                    "valid DNSNone",
-			dnsPolicy:               v1.DNSNone,
-			expectedDNSType:         podDNSNone,
+			desc:            "valid DNSNone",
+			dnsPolicy:       v1.DNSNone,
+			expectedDNSType: podDNSNone,
 		},
 		{
 			desc:          "invalid DNS policy, should return error",
@@ -504,20 +504,20 @@
 	configurer := NewConfigurer(recorder, nodeRef, nil, []net.IP{net.ParseIP(testClusterNameserver)}, testClusterDNSDomain, tmpfile.Name())
 
 	testCases := []struct {
-		desc                    string
-		hostnetwork             bool
-		dnsPolicy               v1.DNSPolicy
-		dnsConfig               *v1.PodDNSConfig
-		expectedDNSConfig       *runtimeapi.DNSConfig
+		desc              string
+		hostnetwork       bool
+		dnsPolicy         v1.DNSPolicy
+		dnsConfig         *v1.PodDNSConfig
+		expectedDNSConfig *runtimeapi.DNSConfig
 	}{
 		{
-			desc:                    "DNSNone without DNSConfig should have empty DNS settings",
-			dnsPolicy:               v1.DNSNone,
-			expectedDNSConfig:       &runtimeapi.DNSConfig{},
+			desc:              "DNSNone without DNSConfig should have empty DNS settings",
+			dnsPolicy:         v1.DNSNone,
+			expectedDNSConfig: &runtimeapi.DNSConfig{},
 		},
 		{
-			desc:                    "DNSNone with DNSConfig should have a merged DNS settings",
-			dnsPolicy:               v1.DNSNone,
+			desc:      "DNSNone with DNSConfig should have a merged DNS settings",
+			dnsPolicy: v1.DNSNone,
 			dnsConfig: &v1.PodDNSConfig{
 				Nameservers: []string{"203.0.113.1"},
 				Searches:    []string{"my.domain", "second.domain"},
@@ -533,8 +533,8 @@
 			},
 		},
 		{
-			desc:                    "DNSClusterFirst with DNSConfig should have a merged DNS settings",
-			dnsPolicy:               v1.DNSClusterFirst,
+			desc:      "DNSClusterFirst with DNSConfig should have a merged DNS settings",
+			dnsPolicy: v1.DNSClusterFirst,
 			dnsConfig: &v1.PodDNSConfig{
 				Nameservers: []string{"10.0.0.11"},
 				Searches:    []string{"my.domain"},
@@ -550,9 +550,9 @@
 			},
 		},
 		{
-			desc:                    "DNSClusterFirstWithHostNet with DNSConfig should have a merged DNS settings",
-			hostnetwork:             true,
-			dnsPolicy:               v1.DNSClusterFirstWithHostNet,
+			desc:        "DNSClusterFirstWithHostNet with DNSConfig should have a merged DNS settings",
+			hostnetwork: true,
+			dnsPolicy:   v1.DNSClusterFirstWithHostNet,
 			dnsConfig: &v1.PodDNSConfig{
 				Nameservers: []string{"10.0.0.11"},
 				Searches:    []string{"my.domain"},
@@ -568,8 +568,8 @@
 			},
 		},
 		{
-			desc:                    "DNSDefault with DNSConfig should have a merged DNS settings",
-			dnsPolicy:               v1.DNSDefault,
+			desc:      "DNSDefault with DNSConfig should have a merged DNS settings",
+			dnsPolicy: v1.DNSDefault,
 			dnsConfig: &v1.PodDNSConfig{
 				Nameservers: []string{"10.0.0.11"},
 				Searches:    []string{"my.domain"},

Run ./hack/update-gofmt.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 31 Passed Tests