This job view page is being replaced by Spyglass soon. Check out the new job view.
PRhoegaarden: CSI: remove globals in pkg/volume/csi
ResultFAILURE
Tests 2 failed / 30 succeeded
Started2019-02-11 11:37
Elapsed38m29s
Revision243c5ef0c30a72e64107c43646597e11f2007e7b
revisioncfe4abcd734cd6ae67c27d66a3653e2408061628

Test Failures


verify bazel 14s

make verify WHAT=bazel
diff -Naupr -x _output /home/prow/go/src/k8s.io/kubernetes/pkg/volume/csi/BUILD /tmp/verify-bazel.Krg8a3/go/src/k8s.io/kubernetes/pkg/volume/csi/BUILD
--- /home/prow/go/src/k8s.io/kubernetes/pkg/volume/csi/BUILD	2019-02-11 11:37:15.478707375 +0000
+++ /tmp/verify-bazel.Krg8a3/go/src/k8s.io/kubernetes/pkg/volume/csi/BUILD	2019-02-11 11:37:39.365692768 +0000
@@ -15,6 +15,7 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//pkg/features:go_default_library",
+        "//pkg/kubelet/util/pluginwatcher:go_default_library",
         "//pkg/volume:go_default_library",
         "//pkg/volume/csi/csiv0:go_default_library",
         "//pkg/volume/csi/nodeinfomanager:go_default_library",

Run ./hack/update-bazel.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify golint 2m0s

make verify WHAT=golint
Errors from golint:
pkg/volume/csi/csi_plugin.go:249:1: exported method Plugin.Init should have comment or be unexported
pkg/volume/csi/csi_plugin.go:274:1: exported method Plugin.GetPluginName should have comment or be unexported
pkg/volume/csi/csi_plugin.go:278:1: comment on exported method Plugin.GetVolumeName should be of the form "GetVolumeName ..."
pkg/volume/csi/csi_plugin.go:291:1: exported method Plugin.CanSupport should have comment or be unexported
pkg/volume/csi/csi_plugin.go:297:1: exported method Plugin.IsMigratedToCSI should have comment or be unexported
pkg/volume/csi/csi_plugin.go:301:1: exported method Plugin.RequiresRemount should have comment or be unexported
pkg/volume/csi/csi_plugin.go:305:1: exported method Plugin.NewMounter should have comment or be unexported
pkg/volume/csi/csi_plugin.go:377:1: exported method Plugin.NewUnmounter should have comment or be unexported
pkg/volume/csi/csi_plugin.go:404:1: exported method Plugin.ConstructVolumeSpec should have comment or be unexported
pkg/volume/csi/csi_plugin.go:434:1: exported method Plugin.SupportsMountOption should have comment or be unexported
pkg/volume/csi/csi_plugin.go:443:1: exported method Plugin.SupportsBulkVolumeVerification should have comment or be unexported
pkg/volume/csi/csi_plugin.go:452:1: exported method Plugin.NewAttacher should have comment or be unexported
pkg/volume/csi/csi_plugin.go:466:1: exported method Plugin.NewDeviceMounter should have comment or be unexported
pkg/volume/csi/csi_plugin.go:470:1: exported method Plugin.NewDetacher should have comment or be unexported
pkg/volume/csi/csi_plugin.go:484:1: exported method Plugin.CanAttach should have comment or be unexported
pkg/volume/csi/csi_plugin.go:507:1: exported method Plugin.NewDeviceUnmounter should have comment or be unexported
pkg/volume/csi/csi_plugin.go:511:1: exported method Plugin.GetDeviceMountRefs should have comment or be unexported
pkg/volume/csi/csi_plugin.go:519:1: exported method Plugin.NewBlockVolumeMapper should have comment or be unexported
pkg/volume/csi/csi_plugin.go:589:1: exported method Plugin.NewBlockVolumeUnmapper should have comment or be unexported
pkg/volume/csi/csi_plugin.go:618:1: exported method Plugin.ConstructBlockVolumeSpec should have comment or be unexported

Please review the above warnings. You can test via "golint" and commit the result.
If the above warnings do not make sense, you can exempt this package from golint
checking by adding it to hack/.golint_failures (if your reviewer is okay with it).
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 30 Passed Tests