Recent runs || View in Spyglass
PR | justinsb: Simple non-image redirect server |
Result | FAILURE |
Tests | 0 failed / 0 succeeded |
Started | |
Elapsed | 2m28s |
Revision | 0fb7641f19861d589778e52b9566935e29183b7a |
Refs |
126 |
... skipping 163 lines ... go: downloading github.com/cespare/xxhash/v2 v2.1.2 go: downloading github.com/prometheus/procfs v0.8.0 go: downloading google.golang.org/protobuf v1.28.1 go: downloading github.com/mattn/go-runewidth v0.0.13 go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369 go: downloading github.com/rivo/uniseg v0.2.0 cmd/redirectserver/app/handlers.go:184:9: Error return value of `w.Write` is not checked (errcheck) w.Write(data) ^ cmd/redirectserver/pkg/mockgcs/server.go:76:11: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive) } else { return s.serve404(request) } cmd/redirectserver/pkg/mocks3/server.go:65:10: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive) } else { return s.serve404(request) } cmd/redirectserver/pkg/mockgcs/server.go:86:27: `(*Server).serve404` - `request` is unused (unparam) func (s *Server) serve404(request *http.Request) (*http.Response, error) { ^ cmd/redirectserver/pkg/mockgcs/server.go:95:30: `(*Server).serveObject` - `req` is unused (unparam) func (s *Server) serveObject(req *http.Request, object *Object) (*http.Response, error) { ^ cmd/redirectserver/pkg/mocks3/server.go:74:27: `(*Server).serve404` - `request` is unused (unparam) func (s *Server) serve404(request *http.Request) (*http.Response, error) { ^ cmd/redirectserver/pkg/mocks3/server.go:83:30: `(*Server).serveObject` - `req` is unused (unparam) func (s *Server) serveObject(req *http.Request, object *Object) (*http.Response, error) { ^ cmd/redirectserver/pkg/mockgcs/server.go:5:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck) "io/ioutil" ^ cmd/redirectserver/pkg/mocks3/server.go:5:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck) "io/ioutil" ^ Verifying generated ... One or more verify checks failed! See output above... make: *** [Makefile:104: verify] Error 1